BISS and kaffe

Gilles Dauphin dauphin at sig.enst.fr
Tue Mar 18 03:11:12 PST 1997


Hi,

Now I compile biss 0.87 and kaffe 0.82. The biss.jde.LibBrowser works fine.

Just a suggest patch for biss package:

---------file awt.h
#ifdef DEBUG
/*
#define DBG(level,fmt,a...) \
  { if ( Debug & level ) fprintf( stderr, "%2d "fmt, level, ##a); }
#define DBG1(level,fmt,a...) \        
  { if ( Debug & level ) fprintf( stderr, fmt, ##a); }
*/                                    
#define DBG(level,fmt,a)              
#define DBG1(level,fmt,a)             
#else                                 
#define DBG(level,fmt,a...)           
#define DBG1(level,fmt,a...)          
#endif

Please redefine the macro DBG and DGB1. Most of compiler don't understand
the parameter 'a...'

All the following suggest is to avoid a cast on a left hand side
of an assign . Please cast the right hand side.

---------file display.c:

/*  DISPLAY_DATA(lib) = ddata; */     
  unhand(lib)->PData = ddata; 

--------file window.c:
/*  XWINDOW(peer) = wnd; */
  unhand(peer)->PData = wnd;

-------file graphics.c:
/*    XGC(graphics) = gc;   */        
    unhand(graphics)->PData = gc;
 ...
/*    XGC(graphics) = gc;   */ 
    unhand(graphics)->PData = gc;
...
/*  XGC(graphics) = 0;  */
  unhand(graphics)->PData = 0;


------file font.c :
/*  XFONTSTRUCT(metrics)        = (long) fs; */
  unhand(metrics)->PData        = (long) fs;

...
/*    XFONTSTRUCT(metrics) = 0;   */
    unhand(metrics)->PData = 0; 

------file image.c :
/*  PIXMAP(image) = pix; */
  unhand(image)->PDataPix = pix;

...
/*  PIXMAP(image) = 0; */ 
  unhand(image)->PDataPix = 0;


Gilles


More information about the kaffe mailing list