I fully agree, but I don't have the time to do it right now. Patches would be nice. One problem is that we sometimes use JNI prototypes, and sometimes we don't. So it's not always clear whether kaffeh would have to be invoked with -jni or without. But that can be figured out too. - Godmar > > Hello! > > I'm currently investigating the unfortunate effect which the last changes > in java.lang.Class have had on jCVS. I'm affraid that such things will > happen in the future, unless function prototypes are made obligatory. > > Kaffe's configure adds -Wstrict-prototypes to CFLAGS if gcc is used. This > is good, but is doesn't catch the situations, when there is no prototype > at all. > > I suggest adding -Wmissing-prototypes to CFLAGS for gcc. > This will generate a lot of warnings right now, but it could be gradually > corrected. > > The first thing which need to be done, is addind java_lang_Class.h and > some other headers to NOINSTALL_DERIVED_HDRS in include/Makefile.am > > Perhaps all the classes declaring native functions should be processed by > kaffeh. > > Then the sources should be adapted to use the new headers. This is a fair > amount of work, but is is worth doing IMHO. > > At least for newly modified files it could be required to pass > -Wmissing-prototypes without warnings. > > Pavel Roskin > >