[kaffe] CVS kaffe (robilad): down to one warning with jit3

Kaffe CVS cvs-commits at kaffe.org
Thu Jan 17 19:12:30 PST 2008


PatchSet 7684 
Date: 2008/01/18 03:11:16
Author: robilad
Branch: HEAD
Tag: (none) 
Log:
down to one warning with jit3

2008-01-18  Dalibor Topic  <robilad at kaffe.org>

* config/i386/jit3-i386.def: Removed unused nop and unimplemented
instructions. Removed ifdef-ed out code.

Members: 
	ChangeLog:1.5186->1.5187 
	config/i386/jit3-i386.def:1.33->1.34 

Index: kaffe/ChangeLog
diff -u kaffe/ChangeLog:1.5186 kaffe/ChangeLog:1.5187
--- kaffe/ChangeLog:1.5186	Thu Jan 17 21:10:15 2008
+++ kaffe/ChangeLog	Fri Jan 18 03:11:16 2008
@@ -1,3 +1,8 @@
+2008-01-18  Dalibor Topic  <robilad at kaffe.org>
+
+	* config/i386/jit3-i386.def: Removed unused nop and unimplemented 
+	instructions. Removed ifdef-ed out code.
+
 2008-01-17  Dalibor Topic  <robilad at kaffe.org>
 
 	* configure.ac: Disabled zlib-zip by default.
Index: kaffe/config/i386/jit3-i386.def
diff -u kaffe/config/i386/jit3-i386.def:1.33 kaffe/config/i386/jit3-i386.def:1.34
--- kaffe/config/i386/jit3-i386.def:1.33	Wed Jun 14 11:40:00 2006
+++ kaffe/config/i386/jit3-i386.def	Fri Jan 18 03:11:18 2008
@@ -168,23 +168,6 @@
 
 /* --------------------------------------------------------------------- */
 
-define_insn(unimplemented, unimplemented)
-{
-	debug(("instr\t%s\n",__PRETTY_FUNCTION__));
-
-	KAFFEVM_ABORT();
-}
-
-define_insn(nop, nop)
-{
-	debug(("instr\t%s\n",__PRETTY_FUNCTION__));
-
-	OUT(0x90);
-	debug(("nop\n"));
-}
-
-/* --------------------------------------------------------------------- */
-
 define_insn(prologue, prologue_xxx)
 {
 	label* l;
@@ -269,44 +252,6 @@
 		debug(("incl 0x%x\n",(int)&(globalMethod->callsCount)));
 	}
 #endif
-
-#if 0
-	/* If this method uses IEEE, set up the mode here */
-	if (used_ieee_division == true) {
-		OUT(0x68);
-		LOUT(0);
-		OUT(0x68);
-		LOUT(0);
-		debug(("pushl #0\n"));
-		debug(("pushl #0\n"));
-
-		OUT(0xD9);
-		OUT(0x3C);
-		OUT(0x24);
-		debug(("fnstcw (esp)\n"));
-
-		OUT(0x8B);
-		OUT((REG_eax<<3)|0x04);
-		OUT(0x24);
-		debug(("movl (esp),eax\n"));
-
-		OUT(0xB8|REG_eax);
-		LOUT(IEEE_MODE);
-		debug(("movl %d,eax\n", IEEE_MODE));
-
-		OUT(0x89);
-		OUT((REG_eax<<3)|0x44);
-		OUT(0x24);
-		OUT(0x04);
-		debug(("movl eax,4(esp)\n"));
-
-		OUT(0xD9);
-		OUT(0x6C);
-		OUT(0x24);
-		OUT(0x04);
-		debug(("fldcw 4(esp)\n"));
-	}
-#endif
 }
 
 #if defined (HAVE_GCJ_SUPPORT)
@@ -415,37 +360,6 @@
 	debug(("subl #?,ecx\n"));
 	debug(("subl #3*SLOTSIZE,ecx\n"));
 	debug(("movl ecx,esp\n"));
-
-#if 0
-	if (used_ieee_division == true) {
-		OUT(0x81);
-		OUT(0xE8|REG_esp);
-		LOUT(SLOTSIZE);
-
-		debug(("subl #%d,esp\n", SLOTSIZE));
-
-		OUT(0x8B);
-		OUT((REG_eax<<3)|0x04);
-		OUT(0x24);
-		debug(("movl (esp),eax\n"));
-
-		OUT(0xB8|REG_eax);
-		LOUT(IEEE_MODE);
-		debug(("movl %d,eax\n", IEEE_MODE));
-
-		OUT(0x89);
-		OUT((REG_eax<<3)|0x44);
-		OUT(0x24);
-		OUT(0x04);
-		debug(("movl eax,4(esp)\n"));
-
-		OUT(0xD9);
-		OUT(0x6C);
-		OUT(0x24);
-		OUT(0x04);
-		debug(("fldcw 4(esp)\n"));
-	}
-#endif
 }
 
 define_insn(epilogue, epilogue_xxx)
@@ -469,28 +383,6 @@
 	}
 	KaffeJIT3_setEpilogueLabel((uintp)CODEPC);
 
-#if 0
-	/* If this method uses IEEE, restore it */
-	if (used_ieee_division == true) {
-#if 0
-		OUT(0xD9);
-		OUT(0x2C);
-		OUT(0x24);
-		debug(("fldcw (esp)\n"));
-#endif
-		OUT(0xD9);
-		OUT(0x6C);
-		OUT(0x24);
-		OUT(0);
-		debug(("fldcw 0(esp)\n"));
-
-		OUT(0x81);
-		OUT(0xC0|REG_esp);
-		LOUT(8);
-		debug(("addl 8,esp\n"));
-	}
-#endif
-
 #if defined(KAFFE_PROFILER)
 	if (profFlag) {
 		profiler_end(globalMethod->totalClicks, 1);
@@ -1023,15 +915,8 @@
 
 	/* Setup EDX - should contains the sign of EAX */
 	do_move_int(REG_edx, REG_eax);
-#if 0
-	OUT(0xC1);
-	OUT(0xF8|REG_edx);
-	OUT(31);
-	debug(("sarl #31,edx\n"));
-#else
 	OUT(0x99);
 	debug(("cltd\n"));
-#endif
 
 	OUT(0xF7);
         OUT(0xF8|r);
@@ -1121,15 +1006,8 @@
 
 	/* Setup EDX - should contains the sign of EAX */
 	do_move_int(REG_edx, REG_eax);
-#if 0
-	OUT(0xC1);
-	OUT(0xF8|REG_edx);
-	OUT(31);
-	debug(("sarl #31,edx\n"));
-#else
 	OUT(0x99);
 	debug(("cltd\n"));
-#endif
 
 	OUT(0xF7);
         OUT(0xF8|r);
@@ -1414,45 +1292,6 @@
 	debug(("fild %d(ebp)\n", r));
 }
 
-#if 0
-
-	We cannot use these functions since the long is store in the
-	opposite order to what they expect.
-
-define_insn(cvt_long_float, cvtlf_RxR)
-{
-	int r;
-
-	debug(("instr\t%s\n",__PRETTY_FUNCTION__));
-
-	r = rslot_long(2);
-	wreg_float(0);
-
-	OUT(0xDF);
-	OUT(0xA8|REG_ebp);
-	LOUT(r);
-
-	debug(("fildll %d(ebp)\n", r));
-}
-
-define_insn(cvt_long_double, cvtld_RxR)
-{
-	int r;
-
-	debug(("instr\t%s\n",__PRETTY_FUNCTION__));
-
-	r = rslot_long(2);
-	wreg_double(0);
-
-	OUT(0xDF);
-	OUT(0xA8|REG_ebp);
-	LOUT(r);
-
-	debug(("fildll %d(ebp)\n", r));
-}
-
-#endif
-
 define_insn(cvt_float_double, cvtfd_RxR)
 {
 	int o = rslot_float(2);
@@ -1593,16 +1432,6 @@
 		l->from = CODEPC;
 		debug(("jult %s\n", KaffeJIT3_getLabelName(l)));
 		break;
-#if 0
-	case bule:
-		OUT(0x0F);
-		OUT(0x86);
-		l->at = CODEPC;
-		LOUT(0);
-		l->from = CODEPC;
-		debug(("jule %s\n", KaffeJIT3_getLabelName(l)));
-		break;
-#endif
 	case bugt:
 		OUT(0x0F);
 		OUT(0x87);




More information about the kaffe mailing list