[kaffe] Adler32

Dalibor Topic robilad at kaffe.org
Fri Sep 9 13:56:43 PDT 2005


Mark Wielaard wrote:
> Hi,
> 
> Just created some Adler32 tests for mauve.
> It seems there are two bugs in the default kaffe (zlib based) Adler32
> implementation. The checksum starts at 1, not 0. And the checksum is an
> unsigned int returned as long:
> 
> 2005-09-01  Mark Wielaard  <mark at klomp.org>
> 
>         * libraries/javalib/java/util/zip/Adler32.java
>         (Adler32): Set adler to 1.
>         (reset): Likewise.
>         (getValue): Return unsigned int value.
> 
> With this all the new mauve tests pass.
> But please check carefully since I didn't find any official adler32 test
> vectors.
> 

thanks for the patch, Mark. I've tried it out with the regression test
suite and mauve, and checked it in.

cheers,
dalibor topic




More information about the kaffe mailing list