[kaffe] CVS kaffe (guilhem): Fixlets.

Guilhem Lavaux guilhem at kaffe.org
Sat Jan 1 07:43:51 PST 2005


Marko Kreen wrote:

>On Fri, Dec 31, 2004 at 03:13:07AM -0800, Kaffe CVS wrote:
>  
>
>>Author: guilhem
>>        * kaffe/kaffevm/jni/jni-string.c
>>        (KaffeJNI_NewStringUTF): If data is NULL we should return NULL
>>        directly.
>>    
>>
>
>I'm not familiar with Kaffe code, but:
>
>  BEGIN_EXCEPTION_HANDLING(NULL);
>  if (data == NULL)
>    return NULL
>
>;
>
>Isn't there END_EXCEPTION_HANDLING() missing?
>
>  
>
No it is not missing however the construct should be changed.

>And libraries/javalib/gnu/classpath/VMSystemProperties.java
>does not check for getLocale() == null, so kaffe still crashes:
>
>  
>
Hmm... ok. Thanks. Strange that on my system "LANG=guilhem kaffe 
HelloWorldApp" hasn't triggered anything. :)

Cheers,

Guilhem Lavaux.




More information about the kaffe mailing list