[kaffe] PATCH: consistently separate jitter and backend register ID

[Casey Marshall]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Timothy" == Timothy Stack <stack at cs.utah.edu> writes:

>>  > Working on the MIPS JIT3 I have made some small changes to the >
>> architechture-independent register code for JIT3 that at least
>> allow > the MIPS JIT to pass all the tests in test/internal. To
>> summarize, > slotRegister now returns the `jitter ID' of the
>> assigned register (the > index into the reginfo array), instead of
>> the `backend ID'. All code > that depends on the former is
>> unchanged, and all code that depends on > the latter now uses a new
>> macro, `slotRegisterRegister', that is > equivalent to
>> slotRegister, but returns the backend ID.
>> 
>> Okie, I'll take a look at this and check it in tonight/tomorrow
>> morning.

Timothy> I looked at the patch, but I'm not totally convinced its the
Timothy> right thing to do...

Me neither. I instead changed `slotAlias' to use regno, and not the
return value of `slotRegister'.

However, I tried something similar to this on x86 and it didn't
work. I haven't tried this approach (attached) on x86 yet.

Timothy> I'd really prefer something that had stronger typing so that
Timothy> these mistakes don't continue to happen.  For example, the
Timothy> x86 backend mixes up uses of the jitter ID for a register and
Timothy> the backend ID.  Its a little trivial, but still...

I'm in favor of Kevin's idea of renaming one of the two `regno'
members in the two structs (`kregs' and `SlotData').

Cheers,

- -- 
Casey Marshall || rsdio at metastatic.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.7 <http://mailcrypt.sourceforge.net/>

iD8DBQFAVfHigAuWMgRGsWsRAsv9AJwL06bDJnTSYxJUfSkYGO4es9EFuwCfVKBI
LUqHxizwTTg9Kas4Q3p333Y=
=bx2x
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: slotAlias.patch
Type: text/x-patch
Size: 843 bytes
Desc: not available
Url : http://pogo.kaffe.org/pipermail/kaffe/attachments/20040315/6839556b/slotAlias-0002.bin