[kaffe] CVS kaffe (dalibor): Fixed turning off native AWT backends

Dalibor Topic robilad at kaffe.org
Sun Jul 25 06:56:38 PDT 2004


Helmer Krämer wrote:
> On Fri, 23 Jul 2004 19:18:34 -0700
> Kaffe CVS <cvs-commits at kaffe.org> wrote:
> 
> 
>>PatchSet 5005 
>>Date: 2004/07/24 01:43:27
>>Author: dalibor
>>Branch: HEAD
>>Tag: (none) 
>>Log:
>>Fixed turning off native AWT backends
>>
>>2004-07-24  Dalibor Topic  <topic at mpi-sb.mpg.de>
>>
>>        Fixed disabling of native AWT code.
>>
>>        * Makefile.am (DIRECTORIES_AFTER_RTJAR): Added explicit support
>>        for AWT directories to ensure that disabling of native
>>        directories works.
>>
>>        * libraries/clib/awt/Makefile.am: Added handling of COND_KAFFE_X_AWT,
>>        COND_KAFFE_QT_AWT and COND_CLASSPATH_GTK_AWT.
>>        (SUBDIRS) Use conditional cubdirs.
>>        (DIST_SUBDIRS) List all subdirs here.
>>
>>        * libraries/clib/Makefile.am: Added handling of COND_NATIVE_AWT.
> 
> 
> I don't think that this combination makes sense. Since
> we don't want to include all the awt classes in the jar
> file Klasses.jar.bootstrap (do we?), we have to build
> the native awt stuff after rt.jar, which is done by adding
> the directories to DIRECTORIES_AFTER_RTJAR. However, also
> adding awt to SUBDIRS in javalib/clib will cause the awt
> stuff to be built before rt.jar, which means that we would
> have to include the awt classes into Klasses.jar.bootstrap.
> 
> Therefore, I would like to commit the attached patch. Could
> you probably try whether it breaks anything?

Hi Helmer,

thanks a lot for catching that bug, too!

cheers,
dalibor topic




More information about the kaffe mailing list