[kaffe] new classpath import

M.Negovanovic milosn@bmf.bounceme.net
Tue Oct 14 15:20:03 2003


On Sun, Oct 12, 2003 at 09:02:29AM +1300, M.Negovanovic wrote:
> OK this new(last) version of the patch has the fix for
> IndexedPropertyDescriptor.java. Please test this out :).
> U do not need any of the previous patches from this email
> thread!!!
> 
> 
> 
> --- CHANGELOG ---
> 
> * libraries/javalib/Makefile.am,
> libraries/javalib/Makefile.in,
> libraries/javalib/profiles/allatonce/all.files,
> libraries/javalib/profiles/default/rest.files:
> Removed java/beans/GenericBeanInfo.java entry.
> 
> * libraries/javalib/gnu/java/beans/BeanInfoEmbryo.java,
> libraries/javalib/gnu/java/beans/ExplicitBeanInfo.java,
> libraries/javalib/gnu/java/beans/IntrospectionIncubator.java,
> libraries/javalib/gnu/java/beans/editors/ColorEditor.java,
> libraries/javalib/gnu/java/beans/editors/FontEditor.java,
> libraries/javalib/gnu/java/beans/editors/NativeBooleanEditor.java,
> libraries/javalib/gnu/java/beans/editors/NativeByteEditor.java,
> libraries/javalib/gnu/java/beans/editors/NativeDoubleEditor.java,
> libraries/javalib/gnu/java/beans/editors/NativeFloatEditor.java,
> libraries/javalib/gnu/java/beans/editors/NativeIntEditor.java,
> libraries/javalib/gnu/java/beans/editors/NativeLongEditor.java,
> libraries/javalib/gnu/java/beans/editors/NativeShortEditor.java,
> libraries/javalib/gnu/java/beans/editors/StringEditor.java,
> libraries/javalib/gnu/java/lang/ArrayHelper.java:
> New classes from GNU Classpath.
> 
> * libraries/javalib/java/beans/IndexedPropertyDescriptor.java:
> Replaced with GNU Classpath class, fixed one typo get->set on line
> 226.
> 
> * libraries/javalib/java/beans/Introspector.java,
> libraries/javalib/java/beans/ParameterDescriptor.java,
> libraries/javalib/java/beans/PropertyChangeEvent.java,
> libraries/javalib/java/beans/PropertyChangeSupport.java,
> libraries/javalib/java/beans/PropertyEditorManager.java,
> libraries/javalib/java/beans/PropertyEditorSupport.java,
> libraries/javalib/java/beans/SimpleBeanInfo.java,
> libraries/javalib/java/beans/VetoableChangeSupport.java:
> Replaced with stuff from GNU Classpath.
>  
> * test/regression/Bean.java:
> Fixed the test.
> 
> --- CHANGELOG ---
> 
> 
> Regards
> Milos

Hi,

Ive looked at the LoaderTest breakage caused by this patch that Dalibor
reported to me:

1) breakage is caused by the differences in java.beans.Introspector
implementations in Kaffe and Classpath.

Kaffe's current Introspector loads BeanInfo with the ClassLoader that
was used to load the Bean class itself , while on the other side
ClassPath's Introspector uses default(?) ClassLoader to load BeanInfo.

2) test breakage is easely fixable with few simple changes in Classpath's
Introspector (i have it fixed in local tree)

What is the "right" way to fix this. Change Classpath's Introspector to
resemble Kaffe's original one ... or change the LoaderTest?

Regards
Milos