[kaffe] CVS kaffe (dalibor): Fixed mauve failure for Hashtable

Kaffe CVS Kaffe Mailing List <kaffe@kaffe.org>
Fri Nov 28 08:18:02 2003


PatchSet 4173 
Date: 2003/11/28 16:15:16
Author: dalibor
Branch: HEAD
Tag: (none) 
Log:
Fixed mauve failure for Hashtable

Members: 
	ChangeLog:1.1765->1.1766 
	libraries/javalib/java/util/Hashtable.java:1.30->1.31 

Index: kaffe/ChangeLog
diff -u kaffe/ChangeLog:1.1765 kaffe/ChangeLog:1.1766
--- kaffe/ChangeLog:1.1765	Thu Nov 27 18:27:12 2003
+++ kaffe/ChangeLog	Fri Nov 28 16:15:16 2003
@@ -1,3 +1,16 @@
+2003-11-28  Dalibor Topic <robilad@kaffe.org>
+
+	Reported by: Mark Wielaard  <mark@klomp.org>
+	
+	* libraries/javalib/java/util/Hashtable.java
+	(contains): Improved comment.
+
+	Reported by: Jeroen Frijters  <jeroen@frijters.net>
+
+	* libraries/javalib/java/util/Hashtable.java
+	(containsValue): Delegate to contains(Object) to make sure older
+	code overwriting it continues to work.
+	
 2003-11-27  Guilhem Lavaux <guilhem@kaffe.org>
 
 	* libraries/javalib/kjc.jar: Regenerated.
Index: kaffe/libraries/javalib/java/util/Hashtable.java
diff -u kaffe/libraries/javalib/java/util/Hashtable.java:1.30 kaffe/libraries/javalib/java/util/Hashtable.java:1.31
--- kaffe/libraries/javalib/java/util/Hashtable.java:1.30	Sun Oct  5 18:25:11 2003
+++ kaffe/libraries/javalib/java/util/Hashtable.java	Fri Nov 28 16:15:18 2003
@@ -334,7 +334,8 @@
   public synchronized boolean contains(Object value)
   {
     /* delegate to non-overridable worker method 
-     * to avoid blowing up the stack.
+     * to avoid blowing up the stack, when called 
+     * from overridden contains[Value]() method.
      */
     return internalContainsValue(value);
   }
@@ -353,10 +354,10 @@
    */
   public boolean containsValue(Object value)
   {
-    /* delegate to non-overridable worker method 
-     * to avoid blowing up the stack.
+    /* delegate to older method to make sure code overwriting it 
+     * continues to work.
      */
-    return internalContainsValue(value);
+    return contains(value);
   }
 
   /**