[kaffe] Re: LinkedList.subList severely broken

[Dalibor Topic]

Hallo Helmer,

--- Helmer Krämer <hkraemer at freenet.de> wrote:
> On Thu, 22 May 2003 05:31:57 -0700 (PDT)
> Dalibor Topic <robilad at yahoo.com> wrote:
> 
> Hi Dalibor,
> 
> > --- Daniel Bonniot <Daniel.Bonniot at inria.fr> wrote:
> > 
> > > I was quite surprised at the behaviour of the build system when some 
> > > code in a library class doesn't compile. It seems that the class (and 
> > > those that require it) are simply left out of rt.jar, but the build does 
> > > not fail. Is there a good reason to do this? I would prefer to see the 
> > > build fail.
> > 
> > Known bug, I just don't know how to fix it, my shell scripting skills are
> not
> > 31337 enough ;) Please take a look at the class file compilation bit in
> > libraries/javalib/Makefile.am. Maybe you can come up with a way that
> prevents
> > the creation of rt.jar when a compilation in the for lop fails. Currently
> it
> > just proceeds ...
> 
> already tried something like this?
> 
>  	$(SHELL) $(rebuildLib) @$(JAVA_MATH_FILES)
>  	for i in `cat $(srcdir)/profiles/$(PROFILE)/profile` ;  do \
> -		$(SHELL) $(rebuildLib) @profiles/$(PROFILE)/$$i ; \
> -		if [ $${?} -ne 0 ]; then \
> -			break ; \
> -		fi ; \
> +		$(SHELL) $(rebuildLib) @profiles/$(PROFILE)/$$i || exit $$? ; \
>  	done
>  	echo timestamp > $(LIBDIR)/stamp

thanks, that worked really well. I've checked it in.

cheers,
dalibor topic

__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com