[kaffe] [AWT] Bug Report: Frame "size" problems

[Dalibor Topic]

--0-630509452-1049115697=:81105
Content-Type: text/plain; charset=us-ascii
Content-Id: 
Content-Disposition: inline

--- Daniel Tschernatsch <daniel.tschernatsch@gmx.de>
wrote:
> In my Application (a game, which hits
> gnu.savannah.org very soon) I need a 
> little bit more consistency of the java.awt.Frame's
> size. I added a Panel to 
> the Frame, that is in control of it's size using the
> getPrefferedSize method. 
> But running my program I ended up with a Frame
> showing my Panel in bigger 
> Dimension(s) than I expected. Calling
> Frame.setResizable(false) doesn't 
> really freeze the size of a Frame since a use can do
> a shade/unshade to have 
> some strange but harmful effect...
> 
> Is this going to be fixed in the next release of
> Kaffe? Hope that anybody 
> takes a look at my problem. I'm sorry, I had no
> chance to try out the CVS 
> version.
> Thank you.

Sorry for the late reply, I hope I can provide some
assistance to solve this problem. I've attached a
preliminary patch against the current CVS and an
updated version of your test program. It should get
the size mostly right, according to the test program.
Only in the end, X seems to dispatch a reparentNotify
event, whatever that's good for, which erases the
insets of the frame, leading to resizing of the panel.
I've got no idea about Xlib programming so it may take
a while until I can figure out what reparentNotify is
good for. Unfortunately, whoever wrote the awt code,
wasn't very keen on commenting its design and
intentions for programmers who haven't got a grasp of
Xlib. Beside that, there is some weirdness within the
event handler hierarchy: kaffe seems to treat the
window closing event as a component event, where sun's
jdk treats it like a window event.

I haven't looked at the shading unshading issue yet,
because I'm not sure what it means ... do you mean you
drag another window over the frame, or do you
iconify/deiconify it?

Could you report back if the patch fixes the problems
you have experienced?

cheers,
dalibor topic

__________________________________________________
Do you Yahoo!?
Yahoo! Platinum - Watch CBS' NCAA March Madness, live on your desktop!
http://platinum.yahoo.com
--0-630509452-1049115697=:81105
Content-Type: application/octet-stream; name=awt-insets-patch
Content-Transfer-Encoding: base64
Content-Description: awt-insets-patch
Content-Disposition: attachment; filename=awt-insets-patch

ZGlmZiAtdXIga2FmZmUvbGlicmFyaWVzL2phdmFsaWIvamF2YS9hd3QvQ29t
cG9uZW50LmphdmEga2FmZmUtcGF0Y2hlZC9saWJyYXJpZXMvamF2YWxpYi9q
YXZhL2F3dC9Db21wb25lbnQuamF2YQotLS0ga2FmZmUvbGlicmFyaWVzL2ph
dmFsaWIvamF2YS9hd3QvQ29tcG9uZW50LmphdmEJMjAwMi0xMS0wMSAxMjoy
MDowNS4wMDAwMDAwMDAgKzAxMDAKKysrIGthZmZlLXBhdGNoZWQvbGlicmFy
aWVzL2phdmFsaWIvamF2YS9hd3QvQ29tcG9uZW50LmphdmEJMjAwMy0wMy0z
MSAxNDo1Nzo1Ny4wMDAwMDAwMDAgKzAyMDAKQEAgLTQ2NCw2ICs0NjQsMTAg
QEAKIAkJcmV0dXJuIG51bGw7CiB9CiAKK3B1YmxpYyBpbnQgZ2V0SGVpZ2h0
KCkgeworCXJldHVybiBoZWlnaHQ7Cit9CisKIHB1YmxpYyBMb2NhbGUgZ2V0
TG9jYWxlICgpIHsKIAlpZiAobG9jYWxlICE9IG51bGwpIHsKIAkJcmV0dXJu
IChsb2NhbGUpOwpAQCAtNTQ5LDYgKzU1MywxMCBAQAogCXJldHVybiB0cmVl
TG9jazsKIH0KIAorcHVibGljIGludCBnZXRXaWR0aCgpIHsKKwlyZXR1cm4g
d2lkdGg7Cit9CisKIHB1YmxpYyBpbnQgZ2V0WCgpIHsKIAlyZXR1cm4geDsK
IH0KT25seSBpbiBrYWZmZS1wYXRjaGVkL2xpYnJhcmllcy9qYXZhbGliL2ph
dmEvYXd0OiBDb21wb25lbnQuamF2YS5+MS4yOC5+CmRpZmYgLXVyIGthZmZl
L2xpYnJhcmllcy9qYXZhbGliL2phdmEvYXd0L0NvbnRhaW5lci5qYXZhIGth
ZmZlLXBhdGNoZWQvbGlicmFyaWVzL2phdmFsaWIvamF2YS9hd3QvQ29udGFp
bmVyLmphdmEKLS0tIGthZmZlL2xpYnJhcmllcy9qYXZhbGliL2phdmEvYXd0
L0NvbnRhaW5lci5qYXZhCTIwMDItMDctMTUgMjE6NTk6MDAuMDAwMDAwMDAw
ICswMjAwCisrKyBrYWZmZS1wYXRjaGVkL2xpYnJhcmllcy9qYXZhbGliL2ph
dmEvYXd0L0NvbnRhaW5lci5qYXZhCTIwMDMtMDMtMzEgMTM6NTQ6MTcuMDAw
MDAwMDAwICswMjAwCkBAIC00MDAsNyArNDAwLDcgQEAKICAgICBzdXBlci5s
aXN0KG91dCwgaW5kZW50KTsKIAogICAgIENvbXBvbmVudFtdIGNvbXBzID0g
Z2V0Q29tcG9uZW50cygpOwotICAgIGZvciAoaW50IGkgPSBjb21wcy5sZW5n
dGggLSAxOyBpID4gMDsgLS1pKSB7CisgICAgZm9yIChpbnQgaSA9IGNvbXBz
Lmxlbmd0aCAtIDE7IGkgPj0gMDsgLS1pKSB7CiAJY29tcHNbaV0ubGlzdChv
dXQsIGluZGVudCArIDIpOwogICAgIH0KIApPbmx5IGluIGthZmZlLXBhdGNo
ZWQvbGlicmFyaWVzL2phdmFsaWIvamF2YS9hd3Q6IENvbnRhaW5lci5qYXZh
Ln4xLjE2Ln4KZGlmZiAtdXIga2FmZmUvbGlicmFyaWVzL2phdmFsaWIvamF2
YS9hd3QvRGVmYXVsdHMuamF2YSBrYWZmZS1wYXRjaGVkL2xpYnJhcmllcy9q
YXZhbGliL2phdmEvYXd0L0RlZmF1bHRzLmphdmEKLS0tIGthZmZlL2xpYnJh
cmllcy9qYXZhbGliL2phdmEvYXd0L0RlZmF1bHRzLmphdmEJMjAwMi0wMS0w
NyAwNDoyNDoxNC4wMDAwMDAwMDAgKzAxMDAKKysrIGthZmZlLXBhdGNoZWQv
bGlicmFyaWVzL2phdmFsaWIvamF2YS9hd3QvRGVmYXVsdHMuamF2YQkyMDAz
LTAzLTMxIDE1OjI2OjI2LjAwMDAwMDAwMCArMDIwMApAQCAtODksNyArODks
NyBAQAogICogYW5kIGxhdGVyIG9uIGNvcnJlY3RlZCAoRnJhbWUuZnJhbWVE
ZWNvKS4gRm9yIHN0YW5kYWxvbmUgZW52aW9ubWVudHMsIHRoaXMgaXMKICAq
IGFuIG9yZGVyCiAgKi8KLQlzdGF0aWMgSW5zZXRzIEZyYW1lSW5zZXRzID0g
bmV3IEluc2V0cyggMjQsNCw0LDQpOworCXN0YXRpYyBJbnNldHMgRnJhbWVJ
bnNldHMgPSBuZXcgSW5zZXRzKCAyNSw1LDUsNSk7CiAvKioKICAqIERpYWxv
ZyBkZWNvcmF0aW9uIGV4dGVuZHMgKHRpdGxlYmFyLCBzaXplLWJvcmRlcnMp
IGluIHBpeGVscy4gRm9yIG5hdGl2ZSB3aW5kb3dpbmcKICAqIHN5c3RlbXMg
KGxpa2UgWCkgdGhpcyBpcyBqdXN0IGEgZ3Vlc3MsIHRvIGJlIHVzZWQgZm9y
IHRoZSBmaXJzdCBEaWFsb2cgdG8gYmUgb3BlbmVkLApPbmx5IGluIGthZmZl
LXBhdGNoZWQvbGlicmFyaWVzL2phdmFsaWIvamF2YS9hd3Q6IERlZmF1bHRz
LmphdmEufjEuMTEufgpkaWZmIC11ciBrYWZmZS9saWJyYXJpZXMvamF2YWxp
Yi9qYXZhL2F3dC9GcmFtZS5qYXZhIGthZmZlLXBhdGNoZWQvbGlicmFyaWVz
L2phdmFsaWIvamF2YS9hd3QvRnJhbWUuamF2YQotLS0ga2FmZmUvbGlicmFy
aWVzL2phdmFsaWIvamF2YS9hd3QvRnJhbWUuamF2YQkyMDAzLTAyLTE5IDIw
OjU2OjE5LjAwMDAwMDAwMCArMDEwMAorKysga2FmZmUtcGF0Y2hlZC9saWJy
YXJpZXMvamF2YWxpYi9qYXZhL2F3dC9GcmFtZS5qYXZhCTIwMDMtMDMtMzEg
MTY6MTE6MTguMDAwMDAwMDAwICswMjAwCkBAIC0xNDgsMTYgKzE0OCwxNiBA
QAogCXJldHVybiAoKGZsYWdzICYgSVNfUkVTSVpBQkxFKSAhPSAwKTsKIH0K
IAotcHVibGljIHZvaWQgbGF5b3V0ICgpIHsKLQkvLyBERVAgLSBzaG91bGQg
YmUgaW4gZG9MYXlvdXQoKQorLy8gcHVibGljIHZvaWQgbGF5b3V0ICgpIHsK
Ky8vIAkvLyBERVAgLSBzaG91bGQgYmUgaW4gZG9MYXlvdXQoKQogCi0Jc3Vw
ZXIubGF5b3V0KCk7CisvLyAJc3VwZXIubGF5b3V0KCk7CiAKLQlpZiAoIGJN
ZW51ICE9IG51bGwpewotCQliTWVudS5zZXRCb3VuZHMoIGZyYW1lRGVjby54
LCBmcmFtZURlY28ueSwKLQkJICAgICAgICAgICAgICAgICB3aWR0aC0oZnJh
bWVEZWNvLndpZHRoKSwgRGVmYXVsdHMuTWVudUJhckhlaWdodCk7Ci0gIH0J
CQotfQorLy8gCWlmICggYk1lbnUgIT0gbnVsbCl7CisvLyAJCWJNZW51LnNl
dEJvdW5kcyggZnJhbWVEZWNvLngsIGZyYW1lRGVjby55LAorLy8gCQkgICAg
ICAgICAgICAgICAgIHdpZHRoLShmcmFtZURlY28ud2lkdGgpLCBEZWZhdWx0
cy5NZW51QmFySGVpZ2h0KTsKKy8vICAgfQkJCisvLyB9CiAKIHB1YmxpYyB2
b2lkIHBhaW50ICggR3JhcGhpY3MgZyApIHsKIC8vc3luY2hyb25pemVkICgg
dHJlZUxvY2sgKSB7CkBAIC0xODgsMjIgKzE4OCw2IEBACiAJCSsgKGlzUmVz
aXphYmxlKCkgPyAiLHJlc2l6YWJsZSIgOiAiLGZpeGVkIik7CiB9CiAKLS8q
KgotICogQGRlcHJlY2F0ZWQsIHVzZSBnZXRQcmVmZXJyZWRTaXplKCkKLSAq
LwotcHVibGljIERpbWVuc2lvbiBwcmVmZXJyZWRTaXplICgpIHsKLQlJbnNl
dHMgICAgaW4gPSBEZWZhdWx0cy5GcmFtZUluc2V0czsKLQlEaW1lbnNpb24g
ZCA9IHN1cGVyLnByZWZlcnJlZFNpemUoKTsKLQkKLQlkLndpZHRoICArPSAo
aW4ubGVmdCArIGluLnJpZ2h0KTsKLQlkLmhlaWdodCArPSAoaW4udG9wICsg
aW4uYm90dG9tKTsKLQkKLQlpZiAoIGJNZW51ICE9IG51bGwgKSB7Ci0JCWQu
aGVpZ2h0ICs9IERlZmF1bHRzLk1lbnVCYXJIZWlnaHQ7Ci0JfQotCXJldHVy
biAoZCk7Ci19Ci0KIHByb3RlY3RlZCB2b2lkIHByb2Nlc3NXaW5kb3dFdmVu
dCAoIFdpbmRvd0V2ZW50IGV2ZW50ICkgewogCS8vIHNob3VsZCBiZSBpbiBX
aW5kb3dzLCBidXQgdGhlIEpESyBkb2N1IHNheXMgV2luZG93cyBkb24ndCB1
bmRlcnN0YW5kCiAJLy8gYWxsIG9mIHRoZSBXaW5kb3dFdmVudHMgKHByb2Jh
Ymx5IGJlY2F1c2UgdGhleSBkaWRuJ3QgaW1wbGVtZW50IHBvcHVwcwpAQCAt
MjQ3LDYgKzIzMSwxMCBAQAogCiBzdGF0aWMgdm9pZCBzZXREZWNvSW5zZXRz
ICggaW50IHRvcCwgaW50IGxlZnQsIGludCBib3R0b20sIGludCByaWdodCwg
aW50IHNyY0lkeCApewogCS8vIHRoaXMgaXMgdGhlIG5hdGl2ZSBjYWxsQmFj
ayB0byBzZXQgZXhhY3QgKGNhbGN1bGF0ZWQpIEZyYW1lIGRlY28gZXh0ZW5k
cworCQkJCSAgICBUaHJvd2FibGUgdCA9IG5ldyBUaHJvd2FibGUoKTsKKwkJ
CQkgICAgdC5maWxsSW5TdGFja1RyYWNlKCk7CisJCQkJICAgIHQucHJpbnRT
dGFja1RyYWNlKFN5c3RlbS5vdXQpOworCQkJCSAgICBTeXN0ZW0ub3V0LnBy
aW50bG4obmV3IEluc2V0cyh0b3AsIGxlZnQsIGJvdHRvbSwgcmlnaHQpKTsK
IAogCWZyYW1lSW5zZXRzLnRvcCAgICA9IHRvcDsKIAlmcmFtZUluc2V0cy5s
ZWZ0ICAgPSBsZWZ0OwpPbmx5IGluIGthZmZlLXBhdGNoZWQvbGlicmFyaWVz
L2phdmFsaWIvamF2YS9hd3Q6IEZyYW1lLmphdmEufjEuMTQufgo=

--0-630509452-1049115697=:81105
Content-Type: application/octet-stream; name="Debug.java"
Content-Transfer-Encoding: base64
Content-Description: Debug.java
Content-Disposition: attachment; filename="Debug.java"

aW1wb3J0IGphdmEuYXd0Lio7CmltcG9ydCBqYXZhLmF3dC5ldmVudC4qOwoK
cHVibGljIGNsYXNzIERlYnVnIGV4dGVuZHMgRnJhbWUgewoKCXByaXZhdGUg
c3RhdGljIFBhbmVsIHA7CgogICAgcHVibGljIERlYnVnKCkgewoJICAgIHAg
PSAKCQkgICAgbmV3IFBhbmVsKCkgewoJCQkgICAgcHVibGljIERpbWVuc2lv
biBnZXRQcmVmZXJyZWRTaXplKCkgewoJCQkJICAgIFRocm93YWJsZSB0ID0g
bmV3IFRocm93YWJsZSgpOwoJCQkJICAgIHQuZmlsbEluU3RhY2tUcmFjZSgp
OwoJCQkJICAgIHQucHJpbnRTdGFja1RyYWNlKFN5c3RlbS5vdXQpOwoJCQkJ
ICAgIAoJCQkJICAgIHJldHVybiBuZXcgRGltZW5zaW9uKDY0MCwgMzcwKTsK
CQkJICAgIH0KCgkJCSAgICBwdWJsaWMgdm9pZCByZXNoYXBlICggaW50IHhO
ZXcsIGludCB5TmV3LCBpbnQgd05ldywgaW50IGhOZXcgKSB7CgkJCQkgICAg
VGhyb3dhYmxlIHQgPSBuZXcgVGhyb3dhYmxlKCk7CgkJCQkgICAgdC5maWxs
SW5TdGFja1RyYWNlKCk7CgkJCQkgICAgdC5wcmludFN0YWNrVHJhY2UoU3lz
dGVtLm91dCk7CgoJCQkJICAgIFN5c3RlbS5vdXQucHJpbnRsbigibmV3OiAi
ICsgIHdOZXcgKyAieCIgKyBoTmV3KTsKCQkJCSAgICBzdXBlci5yZXNoYXBl
KHhOZXcsIHlOZXcsIHdOZXcsIGhOZXcpOwoJCQkgICAgfQoJCSAgICB9OwoJ
ICAgIFN5c3RlbS5vdXQucHJpbnRsbihwKTsKCSAgICBhZGQocCk7CgkgICAg
U3lzdGVtLm91dC5wcmludGxuKHApOwoJICAgIFN5c3RlbS5vdXQucHJpbnRs
bihnZXRJbnNldHMoKSk7CglwYWNrKCk7CgkgICAgU3lzdGVtLm91dC5wcmlu
dGxuKHApOwoJICAgIFN5c3RlbS5vdXQucHJpbnRsbihnZXRJbnNldHMoKSk7
CglzZXRSZXNpemFibGUoZmFsc2UpOwoJYWRkV2luZG93TGlzdGVuZXIobmV3
IFdpbmRvd0FkYXB0ZXIoKSB7CgkgICAgcHVibGljIHZvaWQgd2luZG93Q2xv
c2luZyhXaW5kb3dFdmVudCBlKSB7CgkJICAgIGxpc3QoU3lzdGVtLm91dCwg
MCk7CgkJICAgIFN5c3RlbS5vdXQucHJpbnRsbihnZXRJbnNldHMoKSk7CgkJ
ICAgIFN5c3RlbS5vdXQucHJpbnRsbihwLmdldFdpZHRoKCkgKyAieCIgKyBw
LmdldEhlaWdodCgpKTsKCQkgICAgU3lzdGVtLmV4aXQoMCk7CgkgICAgfQoJ
fSk7CglzZXRWaXNpYmxlKHRydWUpOwogICAgfQoKICAgIHB1YmxpYyBzdGF0
aWMgdm9pZCBtYWluKFN0cmluZ1tdIGFyZ3MpIHsKCW5ldyBEZWJ1ZygpOwog
ICAgfQp9Cg==

--0-630509452-1049115697=:81105--