[kaffe] Odd Jython/jar behaviour

Dalibor Topic robilad at yahoo.com
Tue Jan 7 04:55:02 PST 2003


Hi Vesa,

--- Vesa Kaihlavirta <vpkaihla at cc.jyu.fi> wrote:

> Ok, I got the bug now, though I don't know if my fix
> is the correct one.
> 
> from DataInputStream.java:
> 
> public final int readInt() throws IOException {
> 	int v1 = readUnsignedByte() << 24;
> 	v1 |= readUnsignedByte() << 16;
> 	v1 |= readUnsignedByte() << 8;
> 	v1 |= readUnsignedByte();
> 	return v1;
> }
> 
> In 1.07's version, this was s/UnsignedByte//g (if
> you pardon the expression) 
> -- the bug disappears also with "readByte()" instead
> of "readUnsignedByte()". 
> 
> I'm guessing readByte() is the correct one -- if it
> is, attached patch will 
> fix this.

When I switch from using readUnsignedByte() to using
readByte() I get a ton of failures whan I run make
check. Could you run make check yourself and see if
your patch breaks regressions tests?

best regards,
dalibor topic

__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com




More information about the kaffe mailing list