[kaffe] CVS kaffe (guilhem): Removed too strict regression tests from BufferedReaderTest.
Kaffe CVS
Kaffe Mailing List <kaffe@kaffe.org>
Tue Dec 30 10:26:01 2003
PatchSet 4247
Date: 2003/12/30 18:22:59
Author: guilhem
Branch: HEAD
Tag: (none)
Log:
Removed too strict regression tests from BufferedReaderTest.
Members:
ChangeLog:1.1834->1.1835
test/regression/BufferedReaderTest.java:1.3->1.4
Index: kaffe/ChangeLog
diff -u kaffe/ChangeLog:1.1834 kaffe/ChangeLog:1.1835
--- kaffe/ChangeLog:1.1834 Tue Dec 30 02:22:30 2003
+++ kaffe/ChangeLog Tue Dec 30 18:22:59 2003
@@ -1,3 +1,8 @@
+2003-12-30 Guilhem Lavaux <guilhem@kaffe.org>
+
+ * tests/regression/BufferedReaderTest.java: Removed too strict
+ testcases.
+
2003-12-30 Ito Kazumitsu <kaz@maczuka.gcd.org>
* libraries/javalib/kaffe/io/ByteToCharConverter.java
Index: kaffe/test/regression/BufferedReaderTest.java
diff -u kaffe/test/regression/BufferedReaderTest.java:1.3 kaffe/test/regression/BufferedReaderTest.java:1.4
--- kaffe/test/regression/BufferedReaderTest.java:1.3 Sun Nov 2 13:29:38 2003
+++ kaffe/test/regression/BufferedReaderTest.java Tue Dec 30 18:23:00 2003
@@ -385,55 +385,6 @@
System.out.println(e.toString());
}
- /*
- Actually, that seams to depend on the
- buffer size. I've run tests with different
- buffer sizes, and when the buffer is large
- enough to serve the read ahead buffer and the
- subsequent reads, then reset still works.
- */
-
- sr = new StringReader("ABCDEFGH");
- br = new BufferedReader(sr);
-
- System.out.println("Reset invalidated");
-
- try {
- br.mark(1);
- System.out.println(br.read());
- System.out.println(br.read());
- br.reset();
- }
- catch (Exception e) {
- System.out.println(e.toString());
- }
-
- // let's see what happens when I skip over
- // marked read ahead buffer, when
- // buffer size is large enough to accomodate
- // the requests without the need for refilling.
-
- System.out.println("Skipping over marked buffer");
-
- try {
- br.mark(1);
- br.skip(2);
- System.out.println(br.read());
-
- // According to JDK 1.1.8 behaviour,
- // this should not invalidate the
- // mark. That is a strong hint that
- // mark validation/invalidation should
- // happen in the fillOutBuffer method.
-
- br.reset();
- System.out.println(br.read());
- }
- catch (Exception e) {
- System.out.println(e.toString());
- }
-
-
/* And now to something completely different:
BufferedReader.read (char [], int, int).
@@ -545,7 +496,7 @@
4567
4567
java.lang.NullPointerException
-java.lang.IllegalArgumentException: Buffer size is negative
+java.lang.IllegalArgumentException: Illegal buffer size: 0
1
java.io.IOException: Stream closed
java.io.IOException: Stream closed
@@ -566,12 +517,6 @@
Skipping over marked buffer
69
java.io.IOException: mark never set or invalidated
-Reset invalidated
-65
-66
-Skipping over marked buffer
-67
-65
Null pointer
java.lang.NullPointerException
offset >= buf.length