Two patches

Dalibor Topic kaffe@rufus.w3.org
Thu, 30 Aug 2001 04:28:11 -0700 (PDT)


Hi Oskar,

--- Oskar Sandberg <oskar@freenetproject.org> wrote:
> The first is a problem with BufferedReader, where
> fillOutBuffer() will
> reset the buffer position before reading, so if an
> exception is thrown
> during fillOutBuffer the next read will end up
> returning whatever was in
> the buffer previously (this pretty much only comes
> up when using an
> SoTimeout since most IOExceptions are terminal).
> It's a common bug I
> think, Microsoft's JREs seem to all the problem -
> though Kaffe's
> BufferedInputStream does not. 

Yeah, I see the bug. Your fix looks reasonable. I
didn't think about the possibility of the underlying
reader throwing an IOException when I factored out
that method. [It should also come up if the underlying
reader has been closed]

Dalibor Topic

__________________________________________________
Do You Yahoo!?
Get email alerts & NEW webcam video instant messaging with Yahoo! Messenger
http://im.yahoo.com