sysdepCallMethod for RISC - request for comments

Alexandre Oliva kaffe@rufus.w3.org
03 Mar 2000 23:27:52 -0300


On Mar  2, 2000, Pavel Roskin <pavel_roskin@geocities.com> wrote:

> return longSysdepCallMethod(call, args, func, callargs, calltype)

> and gcc warns:
> `return' with a value, in function returning void

> Is it an error in your implementation?

Probably a thinko, unless the return types changed while I wasn't
looking :-)

Feel free to replace:

  return longSysdepCallMethod(...);

with

  longSysdepCallMethod(...);
  return;

> Also the comment says that longSysdepCallMethod cannot be inlined, but it
> is declared "inline"

The comment also says (at least on alpha) that some day GCC may be
able to inline these, and then, we'll want them to be inlined.

> By the way, what's the reason to use "inline"? And what's the reason to
> use #define for other architectures? Is it only about speed?

Yep, it's only about speed.

> Maybe somebody could clean up sysdepCallMethod for Alpha so that I could
> use it as a base for a better implementation for PowerPC (and eventually
> PA-RISC)?

What do you mean with `clean it up'?  Address the issues you've raised
here or something else?

-- 
Alexandre Oliva     http://www.ic.unicamp.br/~oliva/     Enjoy Guaranį
Cygnus Solutions, a Red Hat company        aoliva@{redhat, cygnus}.com
Free Software Developer and Evangelist    CS PhD student at IC-Unicamp
oliva@{lsd.ic.unicamp.br, gnu.org}   Write to mailing lists, not to me