add arguments to NotImplemented calls
Patrick Tullmann
tullmann at cs.utah.edu
Wed May 19 17:37:47 PDT 1999
Attached is a patch that adds descriptive strings to all of the
remaining kaffe.util.NotImplemented() invocations in Kaffe.
BTW, this is a good way to search for stuff to do in Kaffe (grep for
'NotImplemented' in the java sources... grep for 'XXX' in C code...)
-Pat
1999-05-19 Patrick A Tullmann <tullmann at cs.utah.edu>
* libraries/extensions/servlet/javalib/javax/servlet/http/HttpServlet.java,
libraries/extensions/servlet/javalib/javax/servlet/http/HttpUtils.java,
libraries/javalib/java/awt/GridBagLayout.java,
libraries/javalib/java/lang/ClassLoader.java,
libraries/javalib/java/text/CollationElementIterator.java,
libraries/javalib/java/text/MessageFormat.java,
libraries/javalib/java/text/RuleBasedCollator.java,
libraries/javalib/java/util/GregorianCalendar.java,
libraries/javalib/java/util/Hashtable.java: Add String
argument to all NotImplemented() calls.
Index: libraries/extensions/servlet/javalib/javax/servlet/http/HttpServlet.java
===================================================================
RCS file: /home/cvspublic/kaffe/libraries/extensions/servlet/javalib/javax/servlet/http/HttpServlet.java,v
diff -u -b -r1.1 HttpServlet.java
@@ -25,39 +25,39 @@
}
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpServlet.doGet()");
}
protected long getLastModified(HttpServletRequest req) {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpServlet.getLastModified()");
}
protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpServlet.doPost()");
}
protected void doPut(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpServlet.doPut()");
}
protected void doDelete(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpServlet.doDelete()");
}
protected void doOptions(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpServlet.doOptions()");
}
protected void doTrace(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpServlet.doTrace()");
}
protected void service(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpServlet.service(HttpServletRequest,HttpServletResponse)");
}
public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpServlet.service(ServletRequest,ServletResponse)");
}
}
Index: libraries/extensions/servlet/javalib/javax/servlet/http/HttpUtils.java
===================================================================
RCS file: /home/cvspublic/kaffe/libraries/extensions/servlet/javalib/javax/servlet/http/HttpUtils.java,v
diff -u -b -r1.1 HttpUtils.java
@@ -19,15 +19,15 @@
}
public static Hashtable parseQueryString(String s) {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpUtils.parseQueryString()");
}
public static Hashtable parsePostData(int len, ServletInputStream in) {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpUtils.parsePostData()");
}
public static StringBuffer getRequestURL(HttpServletRequest req) {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("javax/servlet/http/HttpUtils.getRequestURL");
}
}
Index: libraries/javalib/java/awt/GridBagLayout.java
===================================================================
RCS file: /home/cvspublic/kaffe/libraries/javalib/java/awt/GridBagLayout.java,v
diff -u -b -r1.7 GridBagLayout.java
@@ -42,7 +42,7 @@
transient Point offset = new Point();
protected void AdjustForGravity(GridBagConstraints cons, Rectangle display) {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("java.awt.GridBagLayout.AdjustForGravity()");
}
protected void ArrangeGrid(Container container) {
Index: libraries/javalib/java/lang/ClassLoader.java
===================================================================
RCS file: /home/cvspublic/kaffe/libraries/javalib/java/lang/ClassLoader.java,v
diff -u -b -r1.12 ClassLoader.java
@@ -129,7 +129,7 @@
}
public final Enumeration getResources(String name) throws IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("java.lang.ClassLoader.getResources(String)");
}
@@ -142,7 +142,7 @@
}
public static Enumeration getSystemResources(String name) throws IOException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("java.lang.ClassLoader.getSystemResources(String)");
}
static ClassLoader getBaseClassLoader() {
@@ -150,15 +150,15 @@
}
protected Package definePackage(String name, String specTitle, String specVersion, String specVendor, String implTitle, String implVersion, String implVendor, URL sealBase) throws IllegalArgumentException {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("java.lang.ClassLoader.definePackage(String,String,String,String,String,String,String,URL");
}
protected Package getPackage(String name) {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("java.lang.ClassLoader.getPackage(String)");
}
protected Package[] getPackages() {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("java.lang.ClassLoader.getPackages(String)");
}
native private Class defineClass0(String name, byte data[], int offset, int length);
Index: libraries/javalib/java/text/CollationElementIterator.java
===================================================================
RCS file: /home/cvspublic/kaffe/libraries/javalib/java/text/CollationElementIterator.java,v
diff -u -b -r1.5 CollationElementIterator.java
@@ -19,23 +19,23 @@
private CollationElementIterator() {}
public int next() {
- throw new NotImplemented();
+ throw new NotImplemented("java.text.CollationElementIterator.next()");
}
public void reset() {
- throw new NotImplemented();
+ throw new NotImplemented("java.text.CollationElementIterator.reset()");
}
public final static int primaryOrder(int order) {
- throw new NotImplemented();
+ throw new NotImplemented("java.text.CollationElementIterator.primaryOrder(int)");
}
public final static short secondaryOrder(int order) {
- throw new NotImplemented();
+ throw new NotImplemented("java.text.CollationElementIterator.secondaryOrder(int)");
}
public final static short tertiaryOrder(int order) {
- throw new NotImplemented();
+ throw new NotImplemented("java.text.CollationElementIterator.tertiaryOrder(int)");
}
}
Index: libraries/javalib/java/text/MessageFormat.java
===================================================================
RCS file: /home/cvspublic/kaffe/libraries/javalib/java/text/MessageFormat.java,v
diff -u -b -r1.8 MessageFormat.java
@@ -267,7 +267,7 @@
}
public Object[] parse(String str, ParsePosition pos) {
- throw new NotImplemented();
+ throw new NotImplemented("java.text.MessageFormat.parse(String,ParsePosition)");
}
public Object[] parse(String str) throws ParseException {
@@ -292,7 +292,7 @@
}
public String toPattern() {
- throw new NotImplemented();
+ throw new NotImplemented("java.text.MessageFormat.toPattern()");
}
}
Index: libraries/javalib/java/text/RuleBasedCollator.java
===================================================================
RCS file: /home/cvspublic/kaffe/libraries/javalib/java/text/RuleBasedCollator.java,v
diff -u -b -r1.7 RuleBasedCollator.java
@@ -16,7 +16,7 @@
public class RuleBasedCollator extends Collator {
public RuleBasedCollator(String rules) throws ParseException {
- /* NotImplemented */
+ throw new kaffe.util.NotImplemented("java.text.RuleBasedCollator.<init>(String)");
}
public Object clone() {
@@ -47,18 +47,15 @@
}
public CollationElementIterator getCollationElementIterator(String src) {
- /* NotImplemented */
- return (null);
+ throw new kaffe.util.NotImplemented("java.text.RuleBasedCollator.getCollationElementIterator(String)");
}
public CollationKey getCollationKey(String src) {
- /* NotImplemented */
- return (null);
+ throw new kaffe.util.NotImplemented("java.text.RuleBasedCollator.getCollationKey(String)");
}
public String getRules() {
- /* NotImplemented */
- return (null);
+ throw new kaffe.util.NotImplemented("java.text.RuleBasedCollator.getRules()");
}
public int hashCode() {
Index: libraries/javalib/java/util/GregorianCalendar.java
===================================================================
RCS file: /home/cvspublic/kaffe/libraries/javalib/java/util/GregorianCalendar.java,v
diff -u -b -r1.5 GregorianCalendar.java
@@ -75,7 +75,7 @@
public void add(int field, int amount)
{
- throw new NotImplemented();
+ throw new NotImplemented("java.util.GregorianCalendar.add(int,int)");
}
public boolean after(Object when)
@@ -160,21 +160,25 @@
time += fields[DAY_OF_MONTH] - 1;
}
else if (isSet[WEEK_OF_MONTH] && isSet[DAY_OF_WEEK]) {
- throw new NotImplemented();
+ throw new NotImplemented("java.util.GregorianCalendar.computeDateTime() " +
+ "with WEEK_OF_MONTH and DAY_OF_WEEK set.");
}
else if (isSet[DAY_OF_WEEK_IN_MONTH] && isSet[DAY_OF_WEEK]) {
- throw new NotImplemented();
+ throw new NotImplemented("java.util.GregorianCalendar.computeDateTime() " +
+ "with WEEK_OF_MONTH_IN_MONTH and DAY_OF_WEEK set.");
}
}
else if (isSet[DAY_OF_YEAR]) {
time += fields[DAY_OF_YEAR];
}
else if (isSet[DAY_OF_WEEK] && isSet[WEEK_OF_YEAR]) {
- throw new NotImplemented();
+ throw new NotImplemented("java.util.GregorianCalendar.computeDateTime() " +
+ "with DAY_OF_WEEK and WEEK_OF_YEAR set.");
}
}
else {
- throw new NotImplemented();
+ throw new NotImplemented("java.util.GregorianCalendar.computeDateTime() " +
+ "without YEAR set.");
}
time *= 24;
@@ -473,7 +477,7 @@
public void roll(int field, boolean up)
{
- throw new NotImplemented();
+ throw new NotImplemented("java.util.GregorianCalendar.roll(int,boolean)");
}
public void setGregorianChange(Date date)
Index: libraries/javalib/java/util/Hashtable.java
===================================================================
RCS file: /home/cvspublic/kaffe/libraries/javalib/java/util/Hashtable.java,v
diff -u -b -r1.13 Hashtable.java
@@ -375,15 +375,15 @@
}
public Set entrySet() {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("java.util.Hashtable.entrySet()");
}
public Set keySet() {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("java.util.Hashtable.keySet()");
}
public Collection values() {
- throw new kaffe.util.NotImplemented();
+ throw new kaffe.util.NotImplemented("java.util.Hashtable.values()");
}
/*
More information about the kaffe
mailing list