[Kaffe] another ZipOutputStream patch

Archie Cobbs archie at whistle.com
Tue Feb 16 14:45:25 PST 1999


Moses DeJong writes:
> @@ -210,6 +207,7 @@
>                         throw new ZipException("crc not set in stored entry");
>                 }
>         }
> +       ze.flag = ze.method;
>  
>         if (curr == null || curr.method != ze.method) {
>                 if (ze.method == STORED) {

...

> +       put32(lh, LOC_SIGNATURE, (int)LOC_HEADSIG);
> +       put16(lh, LOC_VERSIONEXTRACT, ZIPVER);
> +       put16(lh, LOC_FLAGS, ze.flag);
>  
>         put16(lh, LOC_METHOD, ze.method);
>         put16(lh, LOC_TIME, 0);

Are you sure this is correct? I.e., it's not just that the JDK
is setting the flag to a value that happens to equal the value
of ze.method? Do you have conclusive documentation and/or code
that this is based on?

Just double checking...

Thanks,
-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


More information about the kaffe mailing list