kaffe 0.1.b1

[Archie Cobbs]

Tim Wilkinson writes:
> We have finally released Kaffe 1.0.0 - now formally called Kaffe OpenVM
> 1.0 beta 1.

Cool!!

Can't wait to dig into it some more... in the meantime,
here's my first round of nits... :-)

#0  Email to kaffe at kaffe.org AND kaffe at transvirtual.com is bouncing!

#1  These files are not part of the distribution, but are not
    removed by "make distclean":

      kaffe/scripts/install-jar
      kaffe/scripts/kaffe

#2  These files are part of the distribution, and are removed
    by "make distclean":

      test/HelloWorldApp.class
      libraries/javalib/Klasses.jar

#3  File "libraries/clib/Makefile.in": if "$have_x" is false in
    the configuration, this makefile should not recurse into the
    "awt" subdirectory.

#4  Several makefiles don't understand "make depend".. the patch
    below fixes the ones I found.

-Archie

Index: libraries/clib/awt/Makefile.in
===================================================================
RCS file: /cvs/mod/net/kaffe/libraries/clib/awt/Makefile.in,v
retrieving revision 1.1.1.1
diff -c -u -r1.1.1.1 Makefile.in
--- Makefile.in	1998/07/14 16:49:27	1.1.1.1
+++ Makefile.in	1998/07/14 22:51:58
@@ -24,6 +24,7 @@
 LN=		@LN_S@
 TOUCH=		touch
 DLLTOOL=	@DLLTOOL@
+DEPTOOL=	@DEPTOOL@
 PIC=		@PIC@
 LDFLAGS=	@LIBSHARE@
 LIBS=		@LIBS@
@@ -40,6 +41,8 @@
 
 OBJECT=
 
+DEPENDS=        $(OBJECT:@OBJEXT@=.d)
+
 all:		$(LIB)
 
 OBJECT=\
@@ -65,6 +68,11 @@
 external_wrappers.h:	$(OBJECT)
 		sed -n $(WRAPPER_CMD) $(srcdir)/X/*.c > external_wrappers.h
 
+.SUFFIXES: .d
+ 
+.c.d: 
+		$(DEPTOOL) $(ALL_CFLAGS) $< > $@
+
 clean:
 		rm -f $(LIB) $(OBJECT) lib.exp external_wrappers.h
 
@@ -78,6 +86,10 @@
 		$(INSTALL_DATA) $(LIB) $(nativedir)/$(LIBV)
 		$(LN) $(LIBV) $(nativedir)/$(LIB)
 
+depend:         $(DEPENDS)
+		rm -f .depend
+		cat $(DEPENDS) > .depend
+
 lib.exp:
 		$(DLLTOOL) --def $(srcdir)/$(LIBNAME).def --output-exp lib.exp --output-lib $(LIBNAME).a --dllname $(LIB)
 		touch lib.exp
@@ -98,3 +110,4 @@
 
 X/cbd$(OBJEXT): X/cbd.c X/toolkit.h
 
+ at INC_DEPEND@
Index: libraries/clib/management/Makefile.in
===================================================================
RCS file: /cvs/mod/net/kaffe/libraries/clib/management/Makefile.in,v
retrieving revision 1.1.1.1
diff -c -u -r1.1.1.1 Makefile.in
--- Makefile.in	1998/07/14 16:49:28	1.1.1.1
+++ Makefile.in	1998/07/14 22:51:58
@@ -23,6 +23,7 @@
 MKDIR=		@MKDIR@
 LN=		@LN_S@
 DLLTOOL=	@DLLTOOL@
+DEPTOOL=	@DEPTOOL@
 PIC=		@PIC@
 LDFLAGS=	@LIBSHARE@
 LIBS=		@LIBS@
@@ -42,6 +43,8 @@
 
 OBJECT=		$(OBJECT.KAFFE.MANAGEMENT)
 
+DEPENDS=        $(OBJECT:@OBJEXT@=.d)
+
 all:		$(LIB)
 
 $(LIB):		$(OBJECT) lib.exp external_wrappers.h
@@ -53,6 +56,11 @@
 external_wrappers.h:	$(OBJECT)
 		sed -n $(WRAPPER_CMD) $(srcdir)/*.c > external_wrappers.h
 
+.SUFFIXES: .d
+ 
+.c.d: 
+		$(DEPTOOL) $(ALL_CFLAGS) $< > $@
+
 clean:
 		rm -f $(LIB) $(OBJECT) lib.exp external_wrappers.h
 
@@ -65,6 +73,12 @@
 		$(INSTALL_DATA) $(LIB) $(nativedir)/$(LIBV)
 		$(LN) $(LIBV) $(nativedir)/$(LIB)
 
+depend:         $(DEPENDS)
+		rm -f .depend
+		cat $(DEPENDS) > .depend
+
 lib.exp:
 		$(DLLTOOL) --def $(srcdir)/$(LIBNAME).def --output-exp lib.exp --output-lib $(LIBNAME).a --dllname $(LIB)
 		touch lib.exp
+
+ at INC_DEPEND@
Index: libraries/javalib/Makefile.in
===================================================================
RCS file: /cvs/mod/net/kaffe/libraries/javalib/Makefile.in,v
retrieving revision 1.1.1.2
diff -c -u -r1.1.1.2 Makefile.in
--- Makefile.in	1998/07/14 16:49:28	1.1.1.2
+++ Makefile.in	1998/07/14 22:51:58
@@ -29,6 +29,8 @@
 
 all:
 
+depend:
+
 install:
 		test -d $(classdir) || $(MKDIR) $(classdir)
 		for i in $(JARS) ;\

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com
-- End of included mail.

----- End of forwarded message from Mail Delivery Subsystem -----
___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com